[PATCH] D93631: [clang][cli] Implement `getAllArgValues` marshalling

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 12:53:58 PST 2020


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:338
+                                    const std::vector<std::string> &Values) {
+  for (const std::string& Value : Values) {
+    denormalizeString(Args, Spelling, SA, OptClass, TableIndex, Value);
----------------
Nit: we usually put the `&` next to the variable name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93631/new/

https://reviews.llvm.org/D93631



More information about the llvm-commits mailing list