[PATCH] D93654: [TableGen] Change getAllDerivedDefinitions() to return const vector &

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 12:15:22 PST 2020


Paul-C-Anagnostopoulos added a comment.

Then this does sound like a good idea.

What is the best style for returning the ArrayRef? Just let the return construct it?

return Pair.first->second;

And is it better style to use 'const auto' at all the various places where it's called, or 'const ArrayRef' ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93654/new/

https://reviews.llvm.org/D93654



More information about the llvm-commits mailing list