[PATCH] D93609: [lld/mac] Implement support for private extern symbols

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:382
     in.rebase->addEntry(section, offset);
-    if (defined->isWeakDef() && defined->isExternal())
+    if (defined->isExternalWeakDef())
       in.weakBinding->addEntry(sym, section, offset, addend);
----------------
This is the only change from `defined->isWeakDef() && defined->isExternal()` to `isExternalWeakDef()` where I couldn't come up with a test case that shows the difference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93609/new/

https://reviews.llvm.org/D93609