[PATCH] D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same

[Haowei Wu via Phabricator via llvm-commits]

haowei added inline comments.


================
Comment at: llvm/tools/llvm-elfabi/llvm-elfabi.cpp:74
+    return YAMLErr;
+  OutStr.str();
+
----------------
grimar wrote:
> haowei wrote:
> > grimar wrote:
> > > You don't need this line I think?
> > https://llvm.org/doxygen/raw__ostream_8h_source.html#l00625 I think I need it. It calls flush() to write data into TBEStr, which is why I call it here. I added comment in the new diff.
> Why don't you call `flush()` directly?
I misunderstood the doc. I thought flush() was not a public function. I changed to invoking flush() directly in the latest diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92902/new/

https://reviews.llvm.org/D92902