[PATCH] D93654: [TableGen] Change getAllDerivedDefinitions() to return const vector &

[Chris Lattner via Phabricator via llvm-commits]

lattner accepted this revision.
lattner added a comment.
This revision is now accepted and ready to land.

Did you consider returning `ArrayRef<Record*>` instead?  This is a bit more of an abstract type.  Both work though



================
Comment at: mlir/tools/mlir-tblgen/OpInterfacesGen.cpp:82
+      : defs(defs), os(os) {}
+////  InterfaceGenerator(std::vector<llvm::Record *> &&defs, raw_ostream &os)
+////      : defs(std::move(defs)), os(os) {}
----------------
plz remove the commented out code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93654/new/

https://reviews.llvm.org/D93654