[PATCH] D93239: GlobalISel: Return APInt from getConstantVRegVal

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 09:54:48 PST 2020


bogner accepted this revision.
bogner added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:275
+         "Value found while looking through instrs");
+  if (!ValAndVReg || ValAndVReg->Value.getBitWidth() > 64)
+    return None;
----------------
Why not just call the `APInt` version and add the bitwidth check, rather than duplicating the function?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93239/new/

https://reviews.llvm.org/D93239



More information about the llvm-commits mailing list