[PATCH] D93265: [llvm-objdump-macho] print per-second-level-page encodings for option --unwind-info

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 21 09:44:38 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/MachO/unwind-info-excess-x86_64.test:1
+# RUN: llvm-objdump --unwind-info %p/Inputs/unwind-info-excess.macho-x86_64 2>/dev/null | FileCheck %s
+
----------------
A prebuilt binary is difficult to inspect and update. Can you rewrite the input with yaml2obj?

There are plenty of examples in the ELF/ folder (and in various `test/tools/*/ELF` directories)

The test should also include a file level comment documenting its purpose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93265/new/

https://reviews.llvm.org/D93265



More information about the llvm-commits mailing list