[PATCH] D93272: [InstCombine] Add checking of i1 types when converting select instructions into zext/sext instructions
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 21 08:56:52 PST 2020
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:2673
+ // Do not handle i1 TrueVal and FalseVal otherwise would result in
+ // zext/sext i1 to i1
+ if (SelType->isIntOrIntVectorTy() && !SelType->isIntOrIntVectorTy(1) &&
----------------
Nit: put a period at the end of sentence.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93272/new/
https://reviews.llvm.org/D93272
More information about the llvm-commits
mailing list