[PATCH] D93419: [TableGen] Add the !substr() bang operator

[Jan Svoboda via Phabricator via llvm-commits]

jansvoboda11 added inline comments.


================
Comment at: llvm/include/llvm/TableGen/Record.h:832
 public:
-  enum TernaryOp : uint8_t { SUBST, FOREACH, FILTER, IF, DAG };
+  enum TernaryOp : uint8_t { DAG, FILTER, FOREACH, IF, SUBST, SUBSTR };
 
----------------
Paul-C-Anagnostopoulos wrote:
> jansvoboda11 wrote:
> > Move unrelated/stylistic changes to a separate patch.
> I wouldn't say this is unrelated, since it is the enum that contains SUBSTR. The previous sort order was apparently arbitrary.
I understand.

However, it's a good practice to put formatting changes (and changes that introduce no functionality change) into separate "NFC" commits.
This helps to keep the interesting patches short and easy to understand.

In this case, you can create new NFC patch that reorders the enum cases and rebase this patch on top of the new one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93419/new/

https://reviews.llvm.org/D93419