[PATCH] D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 21 00:54:45 PST 2020
grimar added inline comments.
================
Comment at: llvm/tools/llvm-elfabi/llvm-elfabi.cpp:74
+ return YAMLErr;
+ OutStr.str();
+
----------------
haowei wrote:
> grimar wrote:
> > You don't need this line I think?
> https://llvm.org/doxygen/raw__ostream_8h_source.html#l00625 I think I need it. It calls flush() to write data into TBEStr, which is why I call it here. I added comment in the new diff.
Why don't you call `flush()` directly?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92902/new/
https://reviews.llvm.org/D92902
More information about the llvm-commits
mailing list