[PATCH] D88392: [M68k] (Patch 6/8) IR Tests

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

I see very little by way of testing the return side of the calling convention, and nothing for `sret`.



================
Comment at: llvm/test/CodeGen/M68k/ASM/Alloc/dyn_alloca_aligned.ll:1
+; RUN: llc < %s -mtriple=m68k-linux-gnu -verify-machineinstrs | FileCheck %s -check-prefix=x00
+define i32 @A(i32 %Size) {
----------------
RKSimon wrote:
> Very pedantic - but its more common just to use the default check prefix (CHECK) for a single run instead of a custom (x00) one.
Especially not one that's got lowercase letters in it...


================
Comment at: llvm/test/CodeGen/M68k/ASM/Arith/imul.ll:93
+
+; X64-LABEL: mul40_32_minsize:
+; X64:       jsr __mulsi3
----------------
You don't mean that...


================
Comment at: llvm/test/CodeGen/M68k/ASM/CConv/c-call.ll:15
+
+define i32 @test1() nounwind uwtable {
+entry:
----------------
Do you need uwtable on any of these?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88392/new/

https://reviews.llvm.org/D88392