[PATCH] D93326: [MCInstrDesc] [TableGen] Reduce size of MCOperandInfo instances

Sat Dec 19 12:08:47 PST 2020

craig.topper added a subscriber: dblaikie.
craig.topper added a comment.

I don't think auto-LGTM is consistent with LLVM's code review policy. https://llvm.org/docs/CodeReview.html#code-review-workflow @dblaikie raised this on another review recently https://reviews.llvm.org/D92514

================
Comment at: llvm/include/llvm/MC/MCInstrDesc.h:43
+
+#define MCOI_EARLY_CLOBBER(bit) \
+  ((1 << MCOI::EARLY_CLOBBER) | ((bit) << (4 + MCOI::EARLY_CLOBBER * 4)))
----------------
craig.topper wrote:
> What is "bit" here? There's no data associated with EARLY_CLOBBER. The original code just did (1 << MCOI::EARLY_CLOBBER) to set the flag, there was nothing in the upper bits.
What about this?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93326/new/

https://reviews.llvm.org/D93326