[PATCH] D91837: ADT: Fix reference invalidation in SmallVector APIs that pass in a value

Sat Dec 19 12:02:17 PST 2020

nikic added a comment.

Here are the number I see for this patch:

Instructions retired: https://llvm-compile-time-tracker.com/compare.php?from=2af2f58ec09257d65a2a6f99f833a1b242d434a3&to=1d9e441fa77400d0a97a371b4d9bdbf9c6979266&stat=instructions Geomean 0.2% regression, which is much better than the previous versions (which were something like 1.5%)
Max-RSS: https://llvm-compile-time-tracker.com/compare.php?from=2af2f58ec09257d65a2a6f99f833a1b242d434a3&to=1d9e441fa77400d0a97a371b4d9bdbf9c6979266&stat=max-rss Geomean 0.3% regression (changes here are always a bit mysterious...)
Code size for clang binary: From 82761400 to 82820191, which is a 0.07% increase, which is negligible. (Code size increase with GCC host compiler was a big issue in some of the earlier versions.)

Overall the impact looks reasonable to me now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91837/new/

https://reviews.llvm.org/D91837