[PATCH] D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive

[Yashaswini Hegde via Phabricator via llvm-commits]

yhegde added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:96
   }
+  CheckLoopIv(x);
+}
----------------
clementval wrote:
> Doesn't really check smth but set a state in the context. Should it be renamed ? 
Ok . I can change it to SetLoopInfo . 


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:153
+  case llvm::omp::OMPD_single:
+    for (const auto &dirContext : dirContext_) {
+      if (dirContext.directive == llvm::omp::Directive::OMPD_do) {
----------------
clementval wrote:
> `dirContext_` act as a stack so do you really intent to go from the bottom of the stack to the top? If so no problem. Just asking. 
Yes. Check on nesting is called only if Do directive present in that stack. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93205/new/

https://reviews.llvm.org/D93205