[PATCH] D91441: [VP] Build VP SDNodes

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 17:16:57 PST 2020


kaz7 added inline comments.


================
Comment at: llvm/include/llvm/IR/VPIntrinsics.def:134
 // llvm.vp.sub(x,y,mask,vlen)
-REGISTER_VP_INTRINSIC(vp_sub, 2, 3)
-HANDLE_VP_TO_OPC(vp_sub, Sub)
+HELPER_REGISTER_BINARY_INT_VP(vp_sub, VP_Sub, Sub)
 
----------------
While I'm reviewing https://reviews.llvm.org/D93534, I've just noticed only this one has `VP_Sub`.  Do you like to use `VP_SUB` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91441/new/

https://reviews.llvm.org/D91441



More information about the llvm-commits mailing list