[PATCH] D93569: [lld-macho] Have order files support filtering by archive member paths
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 18 16:03:59 PST 2020
int3 added inline comments.
================
Comment at: lld/MachO/Writer.cpp:502
static size_t getSymbolPriority(const SymbolPriorityEntry &entry,
- const InputFile &file) {
- return std::max(entry.objectFiles.lookup(sys::path::filename(file.getName())),
- entry.anyObjectFile);
+ const InputFile *f) {
+ // We don't use toString(InputFile *) here because it returns the full path
----------------
smeenai wrote:
> Out of curiosity, why the change from reference to pointer? Is it a leftover from an attempt to use toString?
oops yeah it is. I can put the reference back
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93569/new/
https://reviews.llvm.org/D93569
More information about the llvm-commits
mailing list