[PATCH] D93566: [lld-macho][nfc] Use split-file in order file test

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 15:56:15 PST 2020


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

It's a little confusing to have the RUN lines inside the splits IMO. It works fine cos they'll get treated as comments, but I think I'd find this easier to read if you had all the RUNs followed by the order file splits instead of them being interspersed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93566/new/

https://reviews.llvm.org/D93566



More information about the llvm-commits mailing list