[PATCH] D93567: [lld-macho] Support Obj-C symbols in order files

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 15:45:45 PST 2020


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added a subscriber: fedor.sergeev.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Obj-C symbols may have spaces and colons, which our previous order file
parser would be confused by. The order file format has made the very unfortunate
choice of using colons for its delimiters, which means that we have to use
heuristics to determine if a given colon is part of a symbol or not...


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D93567

Files:
  lld/MachO/Driver.cpp
  lld/test/MachO/invalid/order-file-bad-arch.test
  lld/test/MachO/invalid/order-file-bad-objfile.test
  lld/test/MachO/order-file.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93567.312890.patch
Type: text/x-patch
Size: 11075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201218/eb0272ec/attachment.bin>


More information about the llvm-commits mailing list