[PATCH] D93561: [X86] Avoid generating invalid R_X86_64_GOTPCRELX relocations

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 15:40:46 PST 2020


hvdijk marked an inline comment as done.
hvdijk added inline comments.


================
Comment at: llvm/test/MC/X86/gotpcrelx.s:17
+# CHECK-NEXT:     R_X86_64_REX_GOTPCRELX sub
+# CHECK-NEXT:     R_X86_64_REX_GOTPCRELX xor
 # CHECK-NEXT:     R_X86_64_GOTPCRELX mov
----------------
MaskRay wrote:
> Consider moving add R_X86_64_REX_GOTPCRELX instructions below R_X86_64_REX_GOTPCRELX ones.
I'm assuming you meant below R_X86_64_GOTPCRELX :) Sure, pushed with that change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93561/new/

https://reviews.llvm.org/D93561



More information about the llvm-commits mailing list