[PATCH] D93552: [flang] Fix bug in IMPLICIT NONE(EXTERNAL)

[Tim Keith via Phabricator via llvm-commits]

tskeith marked an inline comment as done.
tskeith added inline comments.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:5897
 
+bool ResolveNamesVisitor::CheckImplicitNoneExternal(
+    const SourceName &name, const Symbol &symbol) {
----------------
klausler wrote:
> Could this check be in check-declarations.cpp?
There are a couple of reasons it's easier to do it here:
- we need to track implicit type information by scope and `implict none(external)` goes along with that
- if a procedure is implicitly external we add the EXTERNAL attribute (line 5860) so we have lost the distinction between implicitly and explicitly external


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93552/new/

https://reviews.llvm.org/D93552