[PATCH] D87202: Add a new hidden option -dot-cfg-changes which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:482
+  // Return an iterator to the names of the successor blocks.
+  using llvm::StringMap<std::string>::begin;
+  using llvm::StringMap<std::string>::end;
----------------
In header files, there is a `namespace llvm {}` so `llvm::` can be omitted.

Can the using declarations be omitted?


================
Comment at: llvm/include/llvm/Support/GraphWriter.h:269
+      if (DTraits.renderNodeUsingHTML(Node))
+        O << "<TD COLSPAN=\"1\">... truncated</TD>";
+      else if (i != e)
----------------
Use lower case tags which are more common.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87202/new/

https://reviews.llvm.org/D87202