[PATCH] D91716: AMDGPU/GlobalISel: Calculate isKnownNeverNaN for fminnum and fmaxnum

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fmaxnum.mir:721
     ; GFX9: [[COPY2:%[0-9]+]]:_(s32) = COPY $vgpr2
     ; GFX9: [[FCANONICALIZE2:%[0-9]+]]:_(s32) = G_FCANONICALIZE [[FMAXNUM_IEEE]]
     ; GFX9: [[FCANONICALIZE3:%[0-9]+]]:_(s32) = G_FCANONICALIZE [[COPY2]]
----------------
Petar.Avramovic wrote:
> Thoughts on adding
> ```
> %0:_(s32) = G_FMINNUM_IEEE/G_FMAXNUM_IEEE ...
> %1:_(s32) = G_FCANONICALIZE %0
> ->
> %0:_(s32) = G_FMINNUM_IEEE/G_FMAXNUM_IEEE ...
> %1:_(s32) = COPY %0
> ```
> combine post legalizer?
Yes, redundant canonicalization elimination belongs post legalizer


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91716/new/

https://reviews.llvm.org/D91716