[PATCH] D93482: [flang][openmp] Make Reduction clause part of OmpClause

Fri Dec 18 09:10:32 PST 2020

sameeranjoshi added inline comments.

================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:413-417
 CHECK_SIMPLE_PARSER_CLAUSE(OmpAllocateClause, OMPC_allocate)
 CHECK_SIMPLE_PARSER_CLAUSE(OmpDefaultClause, OMPC_default)
 CHECK_SIMPLE_PARSER_CLAUSE(OmpDistScheduleClause, OMPC_dist_schedule)
 CHECK_SIMPLE_PARSER_CLAUSE(OmpNowait, OMPC_nowait)
 CHECK_SIMPLE_PARSER_CLAUSE(OmpProcBindClause, OMPC_proc_bind)
----------------
clementval wrote:
> sameeranjoshi wrote:
> > A quick question on this- 
> > Why are they not modeled as `OmpClause` nodes any reason ?
> > As I see all of them seem to have definition inside `OMP.td` file.
> Any clause will have a definition in `OMP.td`. If they have a `flangClass` defined it will remove them from OmpClause. 
> 
> I guess we can have a look at all of them and see if there is still a good reason why they are not part of OmpClause. Might be a technical-debt from the refactoring when we switch to TableGen. In OpenACC there is no such clause. 
> 
> Let me know if you want to have a look at this. Otherwise I can do it. 
Let's start with `OMPC_Allocate` clause.
And the reference patch is D93482 
What does technical-debt mean ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93482/new/

https://reviews.llvm.org/D93482