[PATCH] D93549: [flang][OpenMP] Add Fortran Specific Semantic Checks for Allocate Directive

[Irina Dobrescu via Phabricator via llvm-commits]

Rin added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:274
+  if (objectList)
+    CheckObjectListStructure(dir.source, *objectList);
 }
----------------
This functioned is removed and a different one is reused In the General Semantic Checks patch. This should be taken care of after a rebase.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:1072
+    ResolveOmpObjectList(*list, Symbol::Flag::OmpExecutableAllocateDirective);
+  /*const auto
+   * &list{std::get<parser::AllocateStmt<parser::Allocation<parser::AllocateObject>>>(x.t)};*/
----------------
Unnecessary comment here that will be removed


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:373
+  }
+  void ClearExecutableAllocateNames() { executableAllocateNames_.clear(); }
+
----------------
This function is never used, but should be. A place where the ExecutableAllocateNames should be cleared needs to be chosen.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:1065
+          x.t)};
+  if (declarativeList && !list) {
+    context_.Say(x.source,
----------------
The declarativeList is always empty. My assumption is this happens because the declarative allocate appears before the executable one and so the list remains empty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93549/new/

https://reviews.llvm.org/D93549