[PATCH] D92959: [ELF][PPC64] Detect missing R_PPC64_TLSGD/R_PPC64_TLSLD and disable TLS relaxation

Fri Dec 18 09:03:19 PST 2020

MaskRay added inline comments.

================
Comment at: lld/test/ELF/ppc64-tls-missing-gdld.s:20
+
+# WARN: warning: {{.*}}.o:(.text): disable TLS relaxation due to missing R_PPC64_TLSGD/R_PPC64_TLSLD
+
----------------
grimar wrote:
> It reads like the relaxation was disabled for a particular place.
> I.e the message contains the file name and the section name (what is good), but I think the message could mention that the relaxation was disabled for a whole object.
I'll drop the section name. The diagnostic can mention `R_PPC64_GOT_TLS*` then the user should know readelf -r should be used to invesigate the issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92959/new/

https://reviews.llvm.org/D92959