[PATCH] D93548: [AMDGPU][MC][NFC] Parser refactoring

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5146
 
-  Parser.Lex();
-  if (getLexer().isNot(AsmToken::Identifier)) {
-    return MatchOperand_ParseFail;
-  }
-
-  Value = Parser.getTok().getString();
-  return MatchOperand_Success;
+  return parseId(Value) ? MatchOperand_Success : MatchOperand_ParseFail;
 }
----------------
After this change callers of parseStringWithPrefix no longer need to call lex()


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:7354
-  if (Prefix != "dpp8")
-    return parseDPPCtrl(Operands);
-  if (!isGFX10Plus())
----------------
Looks like this call is no longer necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93548/new/

https://reviews.llvm.org/D93548