[PATCH] D93419: [TableGen] Add the !substr() bang operator

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos marked 5 inline comments as done.
Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/include/llvm/TableGen/Record.h:832
 public:
-  enum TernaryOp : uint8_t { SUBST, FOREACH, FILTER, IF, DAG };
+  enum TernaryOp : uint8_t { DAG, FILTER, FOREACH, IF, SUBST, SUBSTR };
 
----------------
jansvoboda11 wrote:
> Move unrelated/stylistic changes to a separate patch.
I wouldn't say this is unrelated, since it is the enum that contains SUBSTR. The previous sort order was apparently arbitrary.


================
Comment at: llvm/lib/TableGen/Record.cpp:1388
   switch (getOpcode()) {
-  case SUBST: Result = "!subst"; break;
-  case FOREACH: Result = "!foreach"; UnquotedLHS = true; break;
+  case DAG: Result = "!dag"; break;
   case FILTER: Result = "!filter"; UnquotedLHS = true; break;
----------------
jansvoboda11 wrote:
> Move unrelated/stylistic changes to a separate patch.
Likewise, the previous sort order was apparently arbitrary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93419/new/

https://reviews.llvm.org/D93419