[PATCH] D93482: [flang][openmp] Make Reduction clause part of OmpClause

sameeran joshi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 08:41:08 PST 2020


sameeranjoshi added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:413-417
 CHECK_SIMPLE_PARSER_CLAUSE(OmpAllocateClause, OMPC_allocate)
 CHECK_SIMPLE_PARSER_CLAUSE(OmpDefaultClause, OMPC_default)
 CHECK_SIMPLE_PARSER_CLAUSE(OmpDistScheduleClause, OMPC_dist_schedule)
 CHECK_SIMPLE_PARSER_CLAUSE(OmpNowait, OMPC_nowait)
 CHECK_SIMPLE_PARSER_CLAUSE(OmpProcBindClause, OMPC_proc_bind)
----------------
A quick question on this- 
Why are they not modeled as `OmpClause` nodes any reason ?
As I see all of them seem to have definition inside `OMP.td` file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93482/new/

https://reviews.llvm.org/D93482



More information about the llvm-commits mailing list