[PATCH] D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:1136
 
+Symbol *OmpAttributeVisitor::ResolveOmpObjectScope(const parser::Name *name) {
+
----------------
Rin wrote:
> clementval wrote:
> > Can you reuse the `ResolveOmpName` function instead of this one? 
> I don't see how ResolveOmpName checks the Scope similarly to the way ResolveOmpObjectScope does. I'm not sure how I could reuse it. I'll take another look at it though.
Fine as well if you cannot reuse it. Can you maybe add a comment on the function to tell how it is different then `ResolveOmpName`? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91159/new/

https://reviews.llvm.org/D91159