[PATCH] D92557: [MachineLICM] delete dead flag if the duplicated def outside of loop is dead.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 18 07:22:31 PST 2020
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:1470
+ // Clear Dup dead flag if any, we reuse it for Reg.
+ const_cast<MachineInstr *>(Dup)->getOperand(Idx).setIsDead(false);
}
----------------
Really should not be using const_cast here
================
Comment at: llvm/test/CodeGen/PowerPC/machinelicm-cse-dead-flag.mir:4
+# RUN: -verify-machineinstrs %s -o - | FileCheck %s
+---
+name: deadFlagAfterCSE
----------------
Add a comment explaining the test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92557/new/
https://reviews.llvm.org/D92557
More information about the llvm-commits
mailing list