[PATCH] D91336: AMDGPU/GlobalISel: Fix negative offset folding for buffer_load

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM. It is correct in more cases than it was before, and it mostly matches what the DAG version does.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:1375
 
   // Handle the variable sgpr + vgpr case.
+  MachineInstr *Add = getOpcodeDef(AMDGPU::G_ADD, CombinedOffset, *MRI);
----------------
The DAG version of setBufferOffsets doesn't have this case. Is it done later on when the register classes are known?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91336/new/

https://reviews.llvm.org/D91336