[PATCH] D93523: [DSE] Use correct memory location for read clobber check

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

> Using the earlier access location means that we can no longer cache which accesses are read for a given killing store, as we may be querying different locations. However, it turns out that simply dropping the cache has no notable impact on compile-time.

Yes that should be fine. There were some major changes after the caching was added which meant that now the 'check-for-reads' loop is not as critical to compile time as before. The cache mostly helped to explore further before running out of budget. So there are some cases we will miss without caching, but from the stats I collected for this patch, it seems there are only minor negative swings and it is best to get this fix in and then potentially tweak it further.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93523/new/

https://reviews.llvm.org/D93523