[PATCH] D91092: [SVE][CodeGen] Lower scalable masked gathers

Bing Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 18 05:42:26 PST 2020


yubing added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1765
+  // Split MemoryVT
+  std::tie(LoMemVT, HiMemVT) = DAG.GetSplitDestVTs(MemoryVT);
+
----------------
Do we really need to split the MemoryType here? I observed that in WidenVecRes_MGATHER, we don't widen the MemoryType.
If we have a v17i32's masked_gather in avx512, we widen it to a v32i32's masked_gather with a v17i32's MemoryType. When the SplitVecRes_MGATHER process this v32i32's masked_gather, line1765 will assert fail since what you are going to split is v17i32.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91092/new/

https://reviews.llvm.org/D91092



More information about the llvm-commits mailing list