[PATCH] D88460: Strlen loop idiom recognition

[Anjan Kumar via Phabricator via llvm-commits]

anjankgk added a comment.

In D88460#2462158 <https://reviews.llvm.org/D88460#2462158>, @hiraditya wrote:

> In D88460#2458205 <https://reviews.llvm.org/D88460#2458205>, @anjankgk wrote:
>
>> In D88460#2342937 <https://reviews.llvm.org/D88460#2342937>, @hiraditya wrote:
>>
>>> It'll be nice to know if this patch worked fine with a set of regression tests.
>>> results on LLVM testsuite, or clang bootstrap will really help.
>>>
>>> Thanks for working on this.
>>
>> Thank you for the feedback @hiraditya! I have tested the latest patch at various options (`O2, O3, LTO and PGO`) against the SPEC benchmarks as well as run the lnt tests and bootstrap tests successfully. If you were concerned about any other specific testsuite, pls let me know.
>
> Nice, if we have performance improvements on any of the benchmarks/workloads then do share.

I did track performance measurements on a bunch of benchmarks but there was nothing noticeable since what this patch is doing is just recognizing the idiom and replacing with the lib call. However, going forward, if we could better the implementation of these library calls (which could be target platform specific) this should give us gains.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88460/new/

https://reviews.llvm.org/D88460