[PATCH] D88390: [M68k] (Patch 4/8) MC layer and object file support

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

a few minors



================
Comment at: llvm/include/llvm/IR/CallingConv.h:248
+    /// M68k_INTR - Calling convention used for M68k interrupt routines.
+    M68k_INTR = 1000,
+
----------------
Why is this 1000 instead of 101?


================
Comment at: llvm/include/llvm/module.modulemap:72
     textual header "BinaryFormat/ELFRelocs/Lanai.def"
+    textual header "BinaryFormat/ELFRelocs/m68k.def"
     textual header "BinaryFormat/ELFRelocs/Mips.def"
----------------
M68k.def ?


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kFixupKinds.h:24
+  LastTargetFixupKind,
+  NumTargetFixupKinds = LastTargetFixupKind - FirstTargetFixupKind
+};
----------------
This looks dodgy - please can you double check it?


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCTargetDesc.cpp:43
+
+// TODO
+static std::string ParseM68kTriple(const Triple &TT, StringRef CPU) {
----------------
todo what?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390