[PATCH] D92902: [llvm-elfabi] Add flag to keep timestamp when output is the same
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 18 01:13:24 PST 2020
grimar added inline comments.
================
Comment at: llvm/lib/InterfaceStub/ELFObjHandler.cpp:723
+ InputData = std::unique_ptr<uint8_t[]>(
+ new uint8_t[FileReadBuffer->getBufferSize()]);
+ memcpy(InputData.get(), FileReadBuffer->getBufferStart(), InputSize);
----------------
grimar wrote:
> nit: I think you should be able to write in the following way to avoid using `new` explicitly:
>
> ```
> InputData = std::unique_ptr<uint8_t[]>(FileReadBuffer->getBufferSize());
> ```
Please ignore this comment. It is an outpdated one that was not posted previously.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92902/new/
https://reviews.llvm.org/D92902
More information about the llvm-commits
mailing list