[PATCH] D68511: [PATCH 17/27] [noalias] Clone scopes and llvm.noalias.decl as needed during loop rotation.

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added inline comments.
Herald added a subscriber: dexonsmith.


================
Comment at: llvm/lib/Transforms/Utils/LoopRotationUtils.cpp:402
+    //    the OrigHeader.
+    // -- when usages are outside the function, and we decide to continue, break
+    //    the connection with the llvm.noalias.decl, as it will have no impact
----------------



================
Comment at: llvm/lib/Transforms/Utils/LoopRotationUtils.cpp:551
+      // (1) -> : ... D' { D U D'' }
+      // (2) -> : ... D' U' { D D'' U'' }
+      // D: original llvm.noalias.decl
----------------
Compared to the (2) above, the `U` element has disappeared. Is it intended?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68511/new/

https://reviews.llvm.org/D68511