[PATCH] D93514: [RISCV] Add intrinsics for vmv.v.v, vmv.v.x, and vmv.x.i

[Zakk Chen via Phabricator via llvm-commits]

khchen accepted this revision.
khchen added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:231
   }
 
+  class RISCVUnary : Intrinsic<[llvm_anyvector_ty],
----------------
Nit: add comment for consistent?
like `// Input: (vector_in/scalar_in, vl)`


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vmv.v.v-rv32.ll:295
+; CHECK:       vsetvli {{.*}}, a0, e8,mf8
+; CHECK:       vmv.v.i {{v[0-9]+}}, 9
+  %a = call <vscale x 1 x i8> @llvm.riscv.vmv.v.x.nxv1i8.i8(
----------------
Could we use negative constant to test `vmv.v.i`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93514/new/

https://reviews.llvm.org/D93514