[PATCH] D93108: [RISCV] Define vwadd/vwaddu/vwsub/vwsubu intrinsics.

Thu Dec 17 19:40:14 PST 2020

HsiangKai added a comment.

In D93108#2459811 <https://reviews.llvm.org/D93108#2459811>, @craig.topper wrote:

> In D93108#2459789 <https://reviews.llvm.org/D93108#2459789>, @fhahn wrote:
>
>> Cross-post from db48a6de7702 <https://reviews.llvm.org/rGdb48a6de7702570083c9b88f4721701b0f2dbfe1>
>>
>> this appears to cause the following warnings when building LLVM with assertions
>>
>>   [1148/2221] Building RISCVGenAsmMatcher.inc...
>>   warning: Compiler has made implicit assumption that TypeSize is not scalable. This may or may not lead to broken code.
>>   [1793/2221] Building RISCVGenAsmWriter.inc...
>>   warning: Compiler has made implicit assumption that TypeSize is not scalable. This may or may not lead to broken code.
>>   [1795/2221] Building RISCVGenCompressInstEmitter.inc...
>>   warning: Compiler has made implicit assumption that TypeSize is not scalable. This may or may not lead to broken code.
>>   [1802/2221] Building RISCVGenRegisterBank.inc...
>>   warning: Compiler has made implicit assumption that TypeSize is not scalable. This may or may not lead to broken code.
>>   [1803/2221] Building RISCVGenRegisterInfo.inc...
>>   warning: Compiler has made implicit assumption that TypeSize is not scalable. This may or may not lead to broken code.
>>   [1805/2221] Building RISCVGenDAGISel.inc...
>>   warning: Compiler has made implicit assumption that TypeSize is not scalable. This may or may not lead to broken code.
>>   [1810/2221] Building RISCVGenGlobalISel.inc...
>>   warning: Compiler has made implicit assumption that TypeSize is not scalable. This may or may not lead to broken code.
>>   [1813/2221] Building RISCVGenInstrInfo.inc...
>>   warning: Compiler has made implicit assumption that TypeSize is not scalable. This may or may not lead to broken code.
>>
>> @HsiangKai it would be great if you could take a look and fix or revert, so we avoid more people having to spend time on tracking this down themselves.
>
> I'm guessing this is coming from the NoVReg class computing a Size of 0?

Indeed, it is caused by NoVReg. I revert it first. I am sorry for the annoying messages caused by my patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93108/new/

https://reviews.llvm.org/D93108