[PATCH] D92493: [IR] Add hot to function attributes and use hot/cold attribute in function section prefix/suffix

[Rong Xu via Phabricator via llvm-commits]

xur added inline comments.


================
Comment at: clang/test/CodeGen/attributes.c:66
 
+// CHECK: define void @t82() [[HOTDEF:#[0-9]+]] {
+void t81(void) __attribute__((hot));
----------------
xur wrote:
> MaskRay wrote:
> > Nit: use `[[#HOTDEF:]]` (which is shorthand for `[[#%u,HOTDEF:]]`
> Thanks. Good to know this format.
@MaskRay: This does not work for me. [[#HOTDEF]] only matches numbers. I put #[[#HOTDEF]] here and add # to the uses later. But the match still failed.

I reverted to old format (also match the existing code. I plan to commit as it is. Feel free to simplify this after my commit. Thanks!




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92493/new/

https://reviews.llvm.org/D92493