[PATCH] D93441: [DebugInfo] Fix crash with -fdebug-info-for-profiling and split dwarf

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

In D93441#2461344 <https://reviews.llvm.org/D93441#2461344>, @dblaikie wrote:

> Yeah - would you be able to see if rather than making changes to support debug-info-for-profiling further in split-dwarf-inlining, we could go the other way and support it less/not at all? (it's going to be a bit annoying, now splitting hairs of having gmlt-without-profiling and gmlt-with-profiling, but hopefully not too drastic *fingers crossed*)

Do you mean `clang -fsplit-dwarf-inlining -fdebug-info-for-profiling` should fail during command line parsing? Or something else?



================
Comment at: llvm/test/DebugInfo/X86/debug-info-for-profiling-crash.ll:4-8
+; struct b {
+;   template <typename c>
+;   void d(c e) { d(e); }
+; };
+; void f() { b a; a.d(0); }
----------------
dblaikie wrote:
> A slightly simpler/more canonical test that seems to reproduce the crash would be:
> ```
> void f1();
> __attribute__((always_inline)) inline void f2() { f1(); }
> void f3() { f2(); }
> ```
> This is the smallest/simplest example of inlining, reproduces without extra instructions at -O0, etc.
Looks like that runs into the second crash I'm looking at, but isn't dwarf-5 specific, so I'll take a look at that :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93441/new/

https://reviews.llvm.org/D93441