[PATCH] D93491: [lld/mac] Add --version flag

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:768-769
 
   if (args.hasArg(OPT_v)) {
     message(getLLDVersion());
     message(StringRef("Library search paths:") +
----------------
I assume that -- unlike for `-v` -- we're intentionally not printing out the library/framework search paths for `--version`... could we update the help text to indicate how `-v` differs? Also, how about handling `OPT_version` here, next to `OPT_v`, just to co-locate similar logic?


================
Comment at: lld/MachO/Options.td:513-515
 def v : Flag<["-"], "v">,
      HelpText<"Print the linker version">,
      Group<grp_rare>;
----------------
I think it'd make sense to put the flag here under `grp_rare`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93491/new/

https://reviews.llvm.org/D93491