[PATCH] D91460: [AsmParser] make .ascii support spaces as separators
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 17 13:42:37 PST 2020
jrtc27 added inline comments.
================
Comment at: llvm/test/MC/AsmParser/directive_ascii.s:52-56
+# CHECK: TEST8:
+# CHECK: .byte 65
+# CHECK: .byte 66
+# CHECK: .byte 67
+# CHECK: .byte 68
----------------
I don't think I understand why these get printed with `.byte` but others with `.ascii`. I think it'd be important to make these use CHECK-NEXT (and CHECK-LABEL) though to assert that there aren't 0s sneaking in (which this test is poor at, the existing cases are not well-written).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91460/new/
https://reviews.llvm.org/D91460
More information about the llvm-commits
mailing list