[PATCH] D92156: [PowerPC] Add support for "tlbiel" with two arguments

Thu Dec 17 13:25:05 PST 2020

nickdesaulniers added a comment.

In D92156#2461086 <https://reviews.llvm.org/D92156#2461086>, @jsji wrote:

> In D92156#2459303 <https://reviews.llvm.org/D92156#2459303>, @nickdesaulniers wrote:
>
>>> Regarding to usage in kernel, I think it depends on which arch are you building for, if it's with -mcpu=pwr9 and above, yes, I would recommend we update the code to use 5 operands basic form.
>>
>> I haven't verified yet that `-mcpu=pwr9` is being used, but it looks like the one TU that's using `tlbie` with 2 operands mixes the use of 2 and 5 operand variants without any kind of check from what I can tell.  If that's the case, we might be able to do:
>
> Great. Thanks. It would be great if we can get rid of 2 operands usage in kernel...

Hmm...might be a while before we can test. Building ppc64le linux kernel with Clang's integrated assembler is a bit of a mess...
$ ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- make CC=clang LLVM_IAS=1 -j71 powernv_defconfig
$ ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- make CC=clang LLVM_IAS=1 -j71 arch/powerpc/mm/book3s64/hash_native.o
...(20+ errors emitted)...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92156/new/

https://reviews.llvm.org/D92156