[PATCH] D93263: [lld-macho] Implement option: -undefined TREATMENT

[Greg McGary via Phabricator via llvm-commits]

gkm marked 3 inline comments as done.
gkm added inline comments.


================
Comment at: lld/test/MachO/invalid/stub-link.s:11
 
-# CHECK-DAG: error: undefined symbol __cache_handle_memory_pressure_event
-# CHECK-DAG: error: undefined symbol _from_non_reexported_tapi_dylib
+# CHECK-DAG: error: undefined symbol '__cache_handle_memory_pressure_event'
+# CHECK-DAG: error: undefined symbol '_from_non_reexported_tapi_dylib'
----------------
int3 wrote:
> this string should probably be changed too?
Ah, I missed this one because it is unsupported on Darwin. I will also test on Linux.


================
Comment at: lld/test/MachO/treat-undef-sym.s:14
+# ERROR: error: undefined symbol: _bar
+# ERROR-NEXT: >>> referenced by
+
----------------
int3 wrote:
> one final nit: why not include the filename here too? Or, if we're just interested in checking for error vs warning, then we could just leave out the check for the "referenced by" line. Checking that those two words exist in isolation doesn't seem super useful...
> 
> (thanks for changing the format string btw)
The intention is to verify that the `>>> referenced by` line occurs. The complete line would include the object filename `%t.o`, but `%t` is not available in that context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93263/new/

https://reviews.llvm.org/D93263