[PATCH] D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata

[Rong Xu via llvm-commits]

On Wed, Dec 2, 2020 at 4:24 PM Matthew Voss via Phabricator <
reviews at reviews.llvm.org> wrote:

> ormris added a comment.
>
> > I would rather to fix this in the memop size transformation -- to detect
> this in the heuristic.
>
> I think it would be valuable to guard against this pattern within the
> transform, but I'm concerned that putting the error in the pass would make
> it harder to debug this issue. If we detect this in llvm-profdata, the user
> is more likely to have/provide the profraw files causing this behavior.
>
I don't think putting this into transformation will make it more
difficult to debug. There are ready many legality heuristics there.
To me, the merge operation should be a straightforward translation from raw
format to index format. We should not put filters there.
A warning is OK but not a filter of profile records.

>
> > Should we do something in profile runtime to prevent this.
>
> Do you think llvm-profdata could be causing this issue? I was thinking
> that profdata might be merging two profiles incorrectly. Either way, having
> the profraw files would be valuable for debugging...
>
There are chances of llvm-prodate bugs but more chances in the compiler-rt
runtime.
Providing the raw profile and the index profile will be very helpful for
the debuging.


>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D92074/new/
>
> https://reviews.llvm.org/D92074
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201217/da9e3521/attachment.html>