[PATCH] D93286: [RISCV] Define vslideup/vslidedown intrinsics and lower to V instructions.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:185
+                    [IntrNoMem]>, RISCVVIntrinsic {
+    let ExtendOperand = 3;
+  }
----------------
Drop ExtendOperand. It shouldn't be needed now.


================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:192
+                    [IntrNoMem]>, RISCVVIntrinsic {
+    let ExtendOperand = 3;
+  }
----------------
Drop ExtendOperand.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vslidedown-rv32.ll:3
+; RUN:   --riscv-no-aliases < %s | FileCheck %s
+declare <vscale x 1 x i8> @llvm.riscv.vslidedown.nxv1i8.i8(
+  <vscale x 1 x i8>,
----------------
This intrinsic name shouldn't have ".i8". It should be ".i32" or dropped.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vslidedown-rv32.ll:9
+
+define <vscale x 1 x i8> @intrinsic_vslidedown_vx_nxv1i8_nxv1i8_i8(<vscale x 1 x i8> %0, <vscale x 1 x i8> %1, i32 %2, i32 %3) nounwind {
+entry:
----------------
Like wise the test name shouldn't have _i8


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93286/new/

https://reviews.llvm.org/D93286