[PATCH] D93065: [InstCombine] Disable optimizations of select instructions that causes propagation of poison values

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D93065#2460747 <https://reviews.llvm.org/D93065#2460747>, @congzhe wrote:

> However, on internal benchmarks I see much less degradation from the freeze solution compared to this patch.
>
> Does this sound like a clue that we should go ahead with the freeze solution? If so I'll post the freeze solution and see how we can go from there.

Ok, the freeze solution might be easier to implement. It seems more straightforward to teach passes to peek through a freeze vs. learn new patterns? I defer to @aqjune and @nikic and other reviewers for opinions/experience. I haven't done that work myself.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93065/new/

https://reviews.llvm.org/D93065