[PATCH] D93366: [RISCV] Define vsadd/vsaddu/vssub/vssubu intrinsics.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 17 10:25:00 PST 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1076
+      unsigned ExtendOp = II->ExtendedOperand + 1;
+      if (ExtendOp) {
+        assert(ExtendOp < Op.getNumOperands());
----------------
I think this if needs to be based on II->ExtendedOperand before adding 1 to it. Otherwise its guaranteed to always be true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93366/new/

https://reviews.llvm.org/D93366



More information about the llvm-commits mailing list