[PATCH] D93229: [VectorCombine] allow peeking through GEPs when creating a vector load
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 17 10:01:19 PST 2020
spatel marked 5 inline comments as done.
spatel added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:159
+
+ OffsetInBits = Offset.getZExtValue() * 8;
+ Alignment = commonAlignment(Alignment, Offset.getZExtValue());
----------------
lebedev.ri wrote:
> Don't we need to ensure that the byte offset is a multiple of element size?
Yes, good catch. We have potentially looked through casts at this point, so anything is possible. I'll add test(s).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93229/new/
https://reviews.llvm.org/D93229
More information about the llvm-commits
mailing list